perf(yaml): use direct assignment for mapping keys#7126
Open
tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
Open
perf(yaml): use direct assignment for mapping keys#7126tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
tomas-zijdemans wants to merge 1 commit intodenoland:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7126 +/- ##
=======================================
Coverage 94.61% 94.61%
=======================================
Files 634 634
Lines 51799 51807 +8
Branches 9329 9334 +5
=======================================
+ Hits 49009 49017 +8
Misses 2216 2216
Partials 574 574 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storeMappingPairandmergeMappingsnow use direct property assignment instead ofObject.definePropertyfor ordinary keys. The descriptorsdefinePropertywas writing ({writable, enumerable, configurable}alltrue) are equivalent to plain assignment, anddefinePropertyis significantly slower in V8.__proto__still goes throughObject.definePropertyto keep the prototype-chain protection in runtimes that enable theObject.prototype.__proto__setter.Based on a wide array of yaml files, I see a consistent 1.24x to 1.43x improvement in mapping-heavy YAML, with no regressions in other payloads