-
Notifications
You must be signed in to change notification settings - Fork 0
Stop returning draft PRs in dependicus #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
bf9997b
1c03b50
0d2a8d1
8839c4b
77ac5eb
4f468a2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2655,7 +2655,16 @@ __metadata: | |
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "semver@npm:^7.3.5, semver@npm:^7.7.3, semver@npm:^7.7.4": | ||
| "semver@npm:^7.3.5": | ||
| version: 7.8.0 | ||
| resolution: "semver@npm:7.8.0" | ||
| bin: | ||
| semver: bin/semver.js | ||
| checksum: 10c0/8f096ca9b80ffd47b308d03f9ce8c873e27e2983f36023c559cdc92c51e8433fc23ebbfe57ec9623fc155636a6961ee989501099841ae4bb1babc8d2b3f048cd | ||
| languageName: node | ||
| linkType: hard | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unintended semver version split in lockfileLow Severity The Reviewed by Cursor Bugbot for commit 4f468a2. Configure here. |
||
|
|
||
| "semver@npm:^7.7.3, semver@npm:^7.7.4": | ||
| version: 7.7.4 | ||
| resolution: "semver@npm:7.7.4" | ||
| bin: | ||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ecosystem branch of legacy arrow pattern is untested
Low Severity
The new
legacyFyiMatchregex accepts an optional ecosystem tag via(?:\[(\w+)\]\s+)?, and the code branches on whetherecosystemis defined to return either${ecosystem}::${dependencyName}or justdependencyName. Only the no-ecosystem path is tested. Every other pattern inextractDependencyNameFromTitlethat handles an ecosystem tag (e.g.,ecoUpdateMatch,ecoFyiMatch) has a dedicated test for the ecosystem path. A regression in the ecosystem capture group (e.g., accidentally making it non-capturing) would go undetected.Additional Locations (1)
src/core/utils/versionUtils.ts#L146-L155Triggered by team rule: tests
Reviewed by Cursor Bugbot for commit 4f468a2. Configure here.