Fix: WordPress anchor links requiring two clicks - use smart click ha…#265
Closed
ralvarez-dg wants to merge 1 commit into
Closed
Fix: WordPress anchor links requiring two clicks - use smart click ha…#265ralvarez-dg wants to merge 1 commit into
ralvarez-dg wants to merge 1 commit into
Conversation
…ndler instead of timeout
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes in-page anchor navigation behavior (notably for WordPress-rendered content) by handling hash-based scrolling on initial load and intercepting #... anchor clicks to scroll without relying on a single delayed timeout.
Changes:
- Replace the fixed
setTimeout-based hash scroll with a retry-based initial-hash handler. - Add a delegated document click handler for
#...anchor links to update the URL and scroll smoothly.
Comment on lines
+64
to
+68
| const handleAnchorClick = (e: MouseEvent) => { | ||
| const target = e.target as HTMLElement; | ||
| if (target.tagName === 'A') { | ||
| const href = target.getAttribute('href'); | ||
| if (href && href.startsWith('#')) { |
Comment on lines
+83
to
+90
| document.addEventListener('click', handleAnchorClick as any); | ||
|
|
||
| // Handle initial page load | ||
| handleInitialHash(); | ||
|
|
||
| return () => { | ||
| document.removeEventListener('click', handleAnchorClick as any); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ndler instead of timeout
Description
Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-ui-react@devgateway/wp-react-libexampleonly (no changeset needed)Checklist
pnpm changeset) for any change to a published packagepnpm buildpasses locallypnpm --filter @devgateway/* typecheckpasses