Adds filter for the cookie name#52
Open
jocastaneda wants to merge 6 commits intodfactoryplugins:masterfrom
Open
Adds filter for the cookie name#52jocastaneda wants to merge 6 commits intodfactoryplugins:masterfrom
jocastaneda wants to merge 6 commits intodfactoryplugins:masterfrom
Conversation
This adds a filter for the cookie name so a plugin or even a theme could
effectively change it without having to modify code to the plugin which
could be reverted back on updates.
A quick example could be used in plugin or perhaps a theme's functions
file:
```
add_filter( 'cn_cookie_name', function($string) {
return 'super_sweet_chocolate_cookie';
}, 10 );
```
|
+1, looks good to me. |
Fixed the conflict introduced as well.
Also fixed merge conflicts introduced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a filter for the cookie name so a plugin or even a theme could effectively change it without having to modify code to the plugin which could be reverted back on updates.
A quick example could be used in plugin or perhaps a theme's functions file:
The nice part is that there wouldn't be a need to edit the JS files since
wp_localize_scriptwill use that value in order to populatecnArgs.cookieNamefor the front-end.This might help with #16 #38 and #50 as well. This way the only code actually being changed is that php line. I'm sure there is a case in which a user might want to name the cookie so this is more of a developer-esque way of going about it.