fix: correct block IDs returned by get_blocks when start is non-zero#10738
Open
Rachit2323 wants to merge 3 commits into
Open
fix: correct block IDs returned by get_blocks when start is non-zero#10738Rachit2323 wants to merge 3 commits into
Rachit2323 wants to merge 3 commits into
Conversation
basvandijk
added
the
security-review-passed
Contributor
Collaborator
|
@Rachit2323 thanks for the contribution. Note there's a clippy error. Also note both of your PRs are drafts. If you want us to review them I suggest to undraft them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
get_blocks(start=5, length=3) returns blocks with wrong IDs (10, 11, 12) instead of correct IDs (5, 6, 7).
The loop variable i already equals the block position, but the code was passing start + i as the block ID — adding start twice by mistake.
Fix
Change decoder(start + i, ...) to decoder(i, ...) — one character fix.
Changes