fix(governance): Correct DeleteSubnet proposal description#10742
Conversation
Drop the "Currently limited to CloudEngine subnets" clause and add the removal of the subnet from the subnet list, which the registry's do_delete_subnet performs but the description omitted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the user-facing documentation/description of the DeleteSubnet NNS proposal to reflect current behavior (removing an outdated CloudEngine limitation note and documenting that the subnet is removed from the subnet list).
Changes:
- Updated the
DeleteSubnetproposal description string used by governance. - Updated the protobuf enum documentation for
DeleteSubnet(and corresponding generated Rust). - Added an entry to the governance unreleased changelog describing the correction.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rs/nns/governance/unreleased_changelog.md | Adds a “Fixed” changelog entry documenting the corrected DeleteSubnet description. |
| rs/nns/governance/src/proposals/execute_nns_function.rs | Updates the ValidNnsFunction::DeleteSubnet human-readable description string. |
| rs/nns/governance/src/gen/ic_nns_governance.pb.v1.rs | Updates the generated Rust enum doc comment for DeleteSubnet to match the corrected description. |
| rs/nns/governance/proto/ic_nns_governance/pb/v1/governance.proto | Updates the source protobuf comment for NNS_FUNCTION_DELETE_SUBNET. |
| rs/nns/governance/api/src/types.rs | Updates the API Rust enum doc comment for DeleteSubnet to match the corrected description. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
|
✅ No security or compliance issues detected. Reviewed everything up to f8b5542. Security Overview
Detected Code Changes
|
… description Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Update the note "Currently limited to CloudEngine subnets" clause (no longer accurate after 65ad179) to saying that system subnets cannot be deleted and add the removal of the subnet from the subnet list, which the registry canister performs but the description omitted.