chore: Use the correct target dir in tests - #760
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed change is focused, and no unresolved issues were found.
Pull request overview
Updates integration-test artifact lookup to respect Cargo’s configured target directory.
Changes:
- Resolves the target directory through
cargo metadata. - Uses that directory to locate generated WASM artifacts.
File summaries
| File | Description |
|---|---|
crates/icp-cli/tests/common/mod.rs |
Corrects test artifact paths for custom Cargo target directories. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
marc0olo
left a comment
marc0olo
left a comment
There was a problem hiding this comment.
Verified the mechanism: cargo metadata in examples/icp-sync-plugin (its own workspace, excluded from the root) resolves the target dir correctly, the default path is identical to the previous hardcoded one, and --no-deps keeps it offline and lockfile-free. Consistent with how the official rust recipe locates the artifact.
Follow-up in a separate PR: the same hardcoded assumption is still in examples/icp-rust/icp.yaml, examples/icp-sync-plugin/icp.yaml and the docs snippets, and our docs pin @dfinity/rust@v3.0.0, which predates the equivalent fix in the recipe (landed in v3.1.0).
No description provided.