Skip to content

[#261]: Refactor document loaders to subclasses#266

Merged
mielvds merged 13 commits into
masterfrom
261-refactor-document-loaders-to-be-subclasses-of-documentloader-base-class
May 18, 2026
Merged

[#261]: Refactor document loaders to subclasses#266
mielvds merged 13 commits into
masterfrom
261-refactor-document-loaders-to-be-subclasses-of-documentloader-base-class

Conversation

@anatoly-scherbakov
Copy link
Copy Markdown
Collaborator

Closes #261

  • Converts built-in requests and aiohttp document loaders to DocumentLoader subclasses while preserving factory call APIs.
  • Adds factory tests for class-based loader instances.
  • Ignores local .venv directories.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 17, 2026

Copy link
Copy Markdown
Collaborator

@mielvds mielvds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anatoly-scherbakov ! Nothing much to add. I would still report this change in the changelog though.

Comment thread lib/pyld/documentloader/aiohttp.py
@anatoly-scherbakov
Copy link
Copy Markdown
Collaborator Author

@mielvds Thanks! Added to the changelog and to the docs.

@mielvds mielvds merged commit fc0309e into master May 18, 2026
16 checks passed
@mielvds mielvds deleted the 261-refactor-document-loaders-to-be-subclasses-of-documentloader-base-class branch May 18, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor document loaders to be subclasses of DocumentLoader base class

2 participants