Skip to content

Fix direction handling and incorrect EulerianDigraph requirement in FacialWalks#931

Open
MeikeWeiss wants to merge 6 commits intodigraphs:mainfrom
MeikeWeiss:meike/planarembedding
Open

Fix direction handling and incorrect EulerianDigraph requirement in FacialWalks#931
MeikeWeiss wants to merge 6 commits intodigraphs:mainfrom
MeikeWeiss:meike/planarembedding

Conversation

@MeikeWeiss
Copy link
Copy Markdown
Contributor

I fixed the issue #930 by really ignoring the direction of the edges. Additionally I fixed the same for FacialWalks and clarified the documentation of DualPlanarGraph. While doing this I realized that FacialWalks requires an EulerianDigraph as an input which is not correct.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.45%. Comparing base (0fe44fd) to head (417cdcc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
- Coverage   97.45%   97.45%   -0.01%     
==========================================
  Files          50       50              
  Lines       21188    21186       -2     
  Branches      639      639              
==========================================
- Hits        20649    20646       -3     
- Misses        474      475       +1     
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant