Hide content type filter when sources are manually included#196
Merged
disnet merged 2 commits intoMay 9, 2026
Merged
Conversation
The content type filter contradicts the user's explicit source picks — if they specifically included a source, filtering it out again by content type is confusing.
disnet
force-pushed
the
radial/3mlf7tjo/when-you-create-a-channel-with-only-incl
branch
from
9df94e7 to
6edee1e
Compare
disnet
deleted the
radial/3mlf7tjo/when-you-create-a-channel-with-only-incl
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typeFilterfrom the saved channel data in that state, so a hidden filter from a prior mode can't silently shrink results when editing.Why
If a user explicitly picks specific sources, they shouldn't then be able to filter them out again by content type — that's contradictory and confusing. The content type filter (
RSS,Skyreader Shares,Standard.site Documents) is only meaningful when the channel is implicitly broad (all sources, or smart-rule-derived).Scope
Only the manual
sourceMode === 'include'case is affected. Smart channels still expose the filter — their rules derive sources by other criteria and combining a content-type filter is still a valid (though debatable) intersection.Test plan
sourceMode=includeandtypeFilterset; confirmtypeFilteris dropped on save.🤖 Generated with Claude Code