Skip to content

fix: use in-memory store in keyring tests to avoid macOS keychain permission dialog #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgageot merged 1 commit into from
Apr 10, 2026
+4 −5
Merged

fix: use in-memory store in keyring tests to avoid macOS keychain permission dialog #2367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions pkg/tools/mcp/tokenstore_keyring_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@ import (
)

func TestKeyringTokenStore_RoundTrip(t *testing.T) {
// Use in-memory fallback for CI environments without a keyring.
// The KeyringTokenStore constructor already falls back to InMemoryTokenStore,
// so this test validates the interface contract regardless of backend.
store := NewKeyringTokenStore()
// Use in-memory store to avoid triggering macOS keychain permission dialogs
// or failing in CI environments without a keyring.
store := NewInMemoryTokenStore()

resourceURL := "https://example.com/mcp"

Expand Down Expand Up @@ -82,7 +81,7 @@ func TestKeyringTokenStore_JSONRoundTrip(t *testing.T) {
}

func TestKeyringTokenStore_RemoveNonExistent(t *testing.T) {
store := NewKeyringTokenStore()
store := NewInMemoryTokenStore()
// Should not error when removing a non-existent token
if err := store.RemoveToken("https://nonexistent.example.com"); err != nil {
t.Fatalf("RemoveToken for non-existent key should not error: %v", err)
Expand Down
Loading