fix(mcp): propagate scopes through dynamic client registration - #3881
Draft
aheritier wants to merge 1 commit into
Draft
fix(mcp): propagate scopes through dynamic client registration#3881aheritier wants to merge 1 commit into
aheritier wants to merge 1 commit into
Conversation
Carry explicitly configured or provider-advertised scopes through DCR-based remote MCP OAuth so registration, authorization, and stored token bookkeeping stay consistent. Adds quote-aware, multi-challenge- continuing WWW-Authenticate parsing, normalizes configured scopes the same way on both the DCR-selection and preflight-coverage sides to avoid a reauth loop, and exercises every resolveClientCredentials branch (explicit client, prompt fallback, successful DCR) with end-to-end scope equality across the registration body, authorize URL, and RequestedScopes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3879
Successful dynamic client registration (DCR) dropped configured or discovered scopes, causing scope mismatches for Atlassian integrations.
Implementation
RequestedScopes.WWW-Authenticateheaders.Testing
Focused and full test suites, lint, build, and race coverage were run.
Follow-up and merge gates