-
Notifications
You must be signed in to change notification settings - Fork 431
fix(runtime): resolve transfer_task caller from pinned session agent #3893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yangtuooc
wants to merge
1
commit into
docker:main
Choose a base branch
from
yangtuooc:fix/background-agent-transfer-task
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[low] Silent fallback to current agent when session
AgentNameis unrecognizedResolveSessionfalls back tor.Current()whensess.AgentNameis non-empty but the named agent is not found in the team (e.g., if an agent was removed or renamed after the session was created). In that edge case,handleTaskTransferwill validate the transfer against the runtime's current agent instead of the session's intended pinned agent — which could either permit a transfer it should reject, or reject one it should permit.This is a new code path introduced by this PR: before the change,
CurrentAgent()was always used (sessions were never pinned), so thesess.AgentName != ""fallback didn't exist. In practice the risk is low because a session referencing a non-existent agent is already an erroneous state, andCurrent()is a reasonable fallback. Consider logging a warning when the named agent is not found (insideResolveSessionor here) so it's observable when this fallback fires.