Skip to content

Remove offset from head/tail calls. This info is already present in t… #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabor-lbl merged 1 commit into from
Feb 26, 2026
Merged

Remove offset from head/tail calls. This info is already present in t… #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions app/demo_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@ def _headtail(
lines: int | None,
skip_heading: bool = False,
skip_trailing: bool = False,
) -> Tuple[Any, int]:
) -> Any:
args = [cmd]

if cmd == "tail" and skip_heading:
Expand All @@ -754,8 +754,7 @@ def _headtail(
args.append(rp)

result = self._run(args)
content = result.stdout
return content, len(content)
return result.stdout

async def head(
self: "DemoAdapter",
Expand All @@ -766,7 +765,7 @@ async def head(
lines: int | None,
skip_trailing: bool = False,
) -> filesystem_models.GetFileHeadResponse:
content, offset = self._headtail("head", path, file_bytes, lines, skip_trailing=skip_trailing)
content = self._headtail("head", path, file_bytes, lines, skip_trailing=skip_trailing)

fc = filesystem_models.FileContent(
content=content,
Expand All @@ -776,7 +775,7 @@ async def head(
start_position=0,
end_position=len(content))

return filesystem_models.GetFileHeadResponse(output=fc, offset=offset)
return filesystem_models.GetFileHeadResponse(output=fc)

async def tail(
self: "DemoAdapter",
Expand All @@ -788,7 +787,7 @@ async def tail(
skip_heading: bool = False,
) -> filesystem_models.GetFileTailResponse:

content, offset = self._headtail("tail", path, file_bytes, lines, skip_heading=skip_heading)
content = self._headtail("tail", path, file_bytes, lines, skip_heading=skip_heading)

fc = filesystem_models.FileContent(
content=content,
Expand All @@ -798,7 +797,7 @@ async def tail(
start_position=0,
end_position=len(content))

return filesystem_models.GetFileTailResponse(output=fc, offset=offset)
return filesystem_models.GetFileTailResponse(output=fc)



Expand Down
2 changes: 0 additions & 2 deletions app/routers/filesystem/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,11 @@ class GetDirectoryLsResponse(BaseModel):
class GetFileHeadResponse(BaseModel):
"""Represents the response for reading the beginning of a file."""
output: FileContent = Field(default=None, description="File content from the beginning")
offset: int = Field(default=0, description="Offset in bytes from the beginning of the file where to start reading the content", example=0)


class GetFileTailResponse(BaseModel):
"""Represents the response for reading the end of a file."""
output: FileContent = Field(default=None, description="File content from the end")
offset: int = Field(default=0, description="Offset in bytes from the beginning of the file where to start reading the content", example=0)


class GetFileChecksumResponse(BaseModel):
Expand Down