chore: Add lock when using SimpleJSON API#2969
Closed
filzrev wants to merge 1 commit intodotnet:masterfrom
Closed
Conversation
timcassell
reviewed
Jan 16, 2026
| lock (lockObject) | ||
| { | ||
| SimpleJsonSerializer.CurrentJsonSerializerStrategy.Indent = IndentJson; | ||
| logger.WriteLine(SimpleJsonSerializer.SerializeObject(GetDataToSerialize(summary))); |
Collaborator
There was a problem hiding this comment.
Write to logger outside of the lock.
Contributor
Author
|
Close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intended to fix #2927 and cleanup namespace that is missing on #2968.