Fix MonoAOT file name not provided error during benchmark generation. #2981
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MonoAOT file name not provided error during benchmark generation.
After updating to latest BDN (and using a dev ASM Resolver version) the performance repo started hitting the error:
With this change (and a dev AsmResolver version) this error seems to be fixed in local MonoAOT testing:
Cause based on copilot investigation:
<Copilot>
Root Cause: The commit 9368a7d ("Update gather references") introduced a bug where the CliPath from CsProjGenerator is passed directly to DotNetCliCommand, but when
options.CliPath is null, the ConfigParser passes an empty string "" instead. The code only handled null using the ?? operator, treating empty strings as valid paths,
which caused Process.Start() to fail with "Cannot start process because a file name has not been provided."
Fix: Changed two locations to use IsBlank() (which checks for null, empty, or whitespace) instead of just null-coalescing:
</ Copilot>