Skip to content

chore: fix SummarySerializationTests on specific Windows environment#2987

Merged
timcassell merged 1 commit intodotnet:masterfrom
filzrev:chore-fix-unittests-crlf-issue
Jan 31, 2026
Merged

chore: fix SummarySerializationTests on specific Windows environment#2987
timcassell merged 1 commit intodotnet:masterfrom
filzrev:chore-fix-unittests-crlf-issue

Conversation

@filzrev
Copy link
Contributor

@filzrev filzrev commented Jan 30, 2026

This PR is follow up of #2970.

On Windows environment.
SimpleJson_SerializeObjectWithUnsupportedNumericValues_ReturnsValidJson test failed with line ending differences. (CRLF/LF)

It's occurred when source code is checked out with LF line endings. (autocrlf option is disabled)

This is a separate matter from the PR content, but it seems don't run unit tests on Windows CI.
Is there a reason for this?

@timcassell timcassell merged commit 12935b2 into dotnet:master Jan 31, 2026
11 checks passed
@timcassell timcassell added this to the v0.16.0 milestone Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants