Repository navigation
Enable transitive pinning and add manual driver dependency health workflow - #4712
cheenamalhotra wants to merge 7 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Transitive pins violate the repository’s TFM version policy, and incomplete daily runs can create unwanted issues.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Enables transitive dependency pinning and adds daily dependency-health automation.
Changes:
- Enables central transitive pinning.
- Adds dependency graph and vulnerability auditing.
- Generates draft dependency-fix PRs with validation and deduplication.
File summaries
| File | Description |
|---|---|
Directory.Packages.props |
Enables transitive pinning. |
.github/workflows/driver-dependency-health.md |
Defines the scheduled audit workflow. |
.github/workflows/driver-dependency-health.lock.yml |
Contains the compiled executable workflow. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 2
- Review effort level: Balanced (auto)
Note
Copilot is running an experiment and ran this review at Balanced.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Incomplete audits can create unwanted issues, and Package-mode validation may not consume the locally packed siblings.
Get a fresh assessment by requesting another Copilot review.
Review details
Suppressed comments (1)
.github/workflows/driver-dependency-health.md:113
report-failure-as-issue: falsedoes not suppress the auto-enabledreport_incompletehandler. The compiled workflow confirmsGH_AW_REPORT_INCOMPLETE_CREATE_ISSUE: "true", so the restore/audit failures routed toreport_incompletebelow will create daily issues despite this comment. Configurereport-incomplete.create-issue: falseas well, then recompile the lock file.
report-incomplete:
- Files reviewed: 2/3 changed files
- Comments generated: 1
- Review effort level: Balanced (auto)
Note
Copilot is running an experiment and ran this review at Balanced.
There was a problem hiding this comment.
🔵 Needs a closer look
Transitive pinning changes published dependency floors, and the new workflow has not yet been validated in hosted execution.
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 0 new
- Review effort level: Balanced (auto)
Note
Copilot is running an experiment and ran this review at Balanced.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Transitive pinning changes published dependency floors, and the extensive agentic workflow has not yet been validated in hosted execution.
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 0 new
- Review effort level: Balanced (auto)
Note
Copilot is running an experiment and ran this review at Balanced.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4712 +/- ##
==========================================
- Coverage 66.21% 64.18% -2.03%
==========================================
Files 290 285 -5
Lines 45063 68082 +23019
==========================================
+ Hits 29838 43699 +13861
- Misses 15225 24383 +9158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
priyankatiwari08
left a comment
There was a problem hiding this comment.
Enabling CentralPackageTransitivePinningEnabled reverses the documented library-packaging decision and changes the dependencies shipped to consumers. The two inline comments cover the specifics, including the unconditional 10.0.3 pins for System.Diagnostics.DiagnosticSource and System.Text.Json, which impose a 10.x floor on net8.0/net9.0 consumers and can trigger NU1605 with direct 8.x/9.x references.
Before merge, please provide a before/after nuspec dependency-group diff for net462, net8.0, and net9.0 and address the consumer compatibility impact. Since the local vulnerability audit was inconclusive and hosted execution remains unverified, keep the workflow dispatch-only until one hosted run succeeds. Also correct net46 to net462 in the workflow scope.
Review scope: Directory.Packages.props and workflow Markdown reviewed in full; generated lock YAML spot-checked only.
Correct the shipping framework scope to net462 and defer daily scheduling until a successful hosted manual run has been reviewed. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
priyankatiwari08
left a comment
There was a problem hiding this comment.
Reviewed Directory.Packages.props and the workflow frontmatter/safe-outputs; the 1856-line generated lock file was skimmed only. Safe-outputs config (draft PR, allowed-files limited to Directory.Packages.props, max: 1) looks right.
- See inline on the transitive-pinning flip.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
priyankatiwari08
left a comment
There was a problem hiding this comment.
Reviewed Directory.Packages.props and the workflow .md; generated lock file not reviewed.
- AKV Provider netstandard2.0 goes from 5 to 18 published deps, including a direct SNI.runtime dependency — consider opting AKV/Azure out of transitive pinning per-project.
| promote pinned transitive dependencies into direct package dependencies. | ||
| --> | ||
| <CentralPackageTransitivePinningEnabled>false</CentralPackageTransitivePinningEnabled> | ||
| <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled> |
There was a problem hiding this comment.
Per your packed comparison, AKV netstandard2.0 now publishes 13 new direct deps incl. Microsoft.Data.SqlClient.SNI.runtime [7.1.0, 8.0.0); set CentralPackageTransitivePinningEnabled=false in the AKV (and Azure) csproj unless those floors are intended.
|
Skipping it for now, not a 'required' change. |

Description
Enable NuGet transitive pinning and add a manually dispatched
driver-dependency-healthagentic workflow. Daily scheduling is deferred until a successful hosted manual run has been reviewed; it is not enabled by this PR or automatically upon merge.CentralPackageTransitivePinningEnabledand replace the contradictory comment. This PR does not introduce package-version updates; the refreshed validation uses the current main-branch .NET 10 targets and 10.0.12 servicing versions.Only
Directory.Packages.props, the workflow Markdown, and its compiled lock YAML are included. No public APIs change; no scratch artifacts or logs are committed.Transitive pinning intentionally raises published minimum dependencies for SDK-packed Azure/AKV packages. Consumers with lower direct references may need to upgrade. The driver's custom nuspec dependency groups remain unchanged; global pinning does not automatically publish every transitive dependency there.
Issues
No linked public issue. Current package-comparison evidence and exact additions: #4712 (comment).
Testing
Refreshed on the current .NET 10 checkout, including comment-only commit
992341205; this supersedes the earlier net8/net9 comparison.gh aw compiletwice: passed, with no semantic generated-lock changes (gh-aw v0.88.2).dotnet build build.proj -t:Pack -p:ReferenceType=Project -p:Configuration=Release -p:PackBuild=true -v:minimal: passed; all six shipping products built/packed.dotnet pack <project> -c Release -p:ReferenceType=Project -p:CentralPackageTransitivePinningEnabled=<false|true> -p:PackageOutputPath=<separate-output-directory> -v:minimal: all 12 passed, with explicit command-line overrides and separate output directories. Compared all embedded nuspec dependency groups, versions, and exclusions. Products: Logging, Abstractions, SqlServer.Server, SqlClient, Azure, and AKV. Full results are in the linked review reply.dotnet build build.proj '-t:TestAbstractions;TestAzure;TestAkvProvider;TestSqlClientUnit;TestSqlClientFunctional' -p:ReferenceType=Project -p:Configuration=Release -p:TestCodeCoverage=false -v:minimal: partially passed. Abstractions (29), Azure (48), and AKV (10) passed on each framework; net10 unit tests passed (1,473). Three net462 certificate-not-found failures stopped the command before functional tests.dotnet build build.proj -t:TestSqlClientUnit -p:ReferenceType=Project -p:Configuration=Release -p:TestFramework=net462 -p:TestCodeCoverage=false -v:minimal: passed, 1,453 tests on isolated rerun. The earlier failure is consistent with concurrent framework runs sharing the certificate fixture.dotnet build build.proj -t:TestSqlClientFunctional -p:ReferenceType=Project -p:Configuration=Release -p:TestCodeCoverage=false -v:minimal: failed, two certificate-store tests per framework explicitly require administrator rights. Other results: 1,337 passed on net10; 1,326 passed on net462. No tests were disabled or machine permissions changed.git diff --check: passed.No persistent test files were added: this change is packaging policy and workflow configuration, verified through actual package generation and existing suites. SQL Server-backed manual tests were not run. Earlier local vulnerability auditing was inconclusive due to TLS/NU1900/NU1905 errors; hosted workflow execution remains unverified.
Guidelines
Please review the contribution guidelines before submitting a pull request:
Contributing
Code of Conduct
Best Practices
Coding Style
Review Process
Workflow source and generated lock file included together.
Public API changes documented: none.
Tests added or updated: no persistent test files; existing suites and package comparisons executed.
Verified against customer repro: not applicable.
Ensure no breaking changes introduced: raised package dependency minimums are intentional and require review.
Operational requirements
Requires
COPILOT_GITHUB_TOKENand permission for GitHub Actions to create PRs. Maintainers must ensure required CI runs for workflow-created PRs. Manual runs are restricted to the default branch. After merge, a successful hosted manual run must be reviewed before a separate change enables the daily schedule.