Repository navigation
[7.1.3 Cherry-pick] Manage SimulatedServer flaky test failures - #5087
Draft
github-actions[bot] wants to merge 2 commits into
Draft
github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
To resolve, run: git cherry-pick c7ab087
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Retain the target release without isolation-level reset tests; only the failover quarantine from c7ab087 applies. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## release/7.1 #5087 +/- ##
===============================================
- Coverage 72.84% 65.80% -7.05%
===============================================
Files 306 300 -6
Lines 45143 68171 +23028
===============================================
+ Hits 32886 44862 +11976
- Misses 12257 23309 +11052
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports the applicable part of #4804 (authored by @cheenamalhotra, merged as c7ab087) to
release/7.1for 7.1.3. The failed cherry-pick is resolved in abb233d.Adds
[Trait("category", "flaky")]toConnectionFailoverTests.NetworkError_TriggersFailover_ClearsPool. Its existing assertions remain unchanged; CI intermittently observes three failover-server pre-logins instead of two after the pool is cleared and the connection is reopened. This routes the test into the existing quarantine steps rather than changing driver behavior.Release-specific resolution: retain the absence of
IsolationLevelResetTests.cs. Neither the isolation-level reset feature nor itsResetSessionIsolationLevel_UsesOpenBudgettest exists onrelease/7.1, so the original PR's setup-login-timeout adjustment does not apply. Do not introduce that feature or test as part of this servicing change.Test-only change. No product code, public APIs, dependencies, localization, or documentation changes.
Issues
Backport of #4804; CI test flakiness, no separate customer issue.
Testing
Validated on Windows using the release branch's .NET 10 SDK and existing test projects. The initial validation attempt found missing NuGet assets;
dotnet restore src\Microsoft.Data.SqlClient\tests\UnitTests\Microsoft.Data.SqlClient.UnitTests.csproj --verbosity quietthen passed without dependency-version changes.Passed: 1, failed: 0, skipped: 0.
Passed: 1, failed: 0, skipped: 0.
Both builds/discovery commands passed and listed exactly the affected test. Before the change, the same .NET 8 discovery command listed no tests with this combined name/category filter, confirming that the quarantine routing changed. Zero-match baseline discovery is not counted as test coverage.
git diff HEAD --checkand the staged whitespace check passed; no unmerged index entries or conflict markers remained. Source and target heads were refreshed and unchanged before the normal non-force push to the existing PR branch. No full test suite or .NET 9/.NET 10 test executions were performed. This remains draft pending CI; local passes do not establish that intermittent failures can no longer occur.Guidelines
Please review the contribution guidelines before submitting a pull request:
Contributing
Code of Conduct
Best Practices
Coding Style
Review Process
Tests added or updated
Public API changes documented (none)
Verified against customer repro (N/A: CI flakiness)
Ensure no breaking changes introduced