Repository navigation
[8.0] Revert connection encryption info public API surface (#5037) - #5090
Open
saurabh500 wants to merge 1 commit into
Open
saurabh500 wants to merge 1 commit into
saurabh500 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Missing revert PR details, immutable base/head identifiers, trusted policy references, and reviewer discussion prevented verification of current-head CI and outstanding feedback.
No open issues 🎉
What changed in this PR
Reverts #5037’s connection-encryption diagnostics API from the 8.0 driver, restoring the prior public surface without changing encryption negotiation or Always Encrypted behavior. Removing these APIs intentionally breaks compilation for applications that reference them.
Changes:
- Removes encryption-information types and properties from implementation and reference assemblies.
- Removes associated documentation, tests, and test utilities while restoring the previous exception serialization test.
- Reverses the feature-specific unsupported-platform GenAPI configuration.
Reported validation includes successful builds and XML documentation checks. The two reported routing-test failures also reproduce before the revert.
| File | Description |
|---|---|
src/Microsoft.Data.SqlClient/tests/UnitTests/Utilities/EncryptionInfoTestData.cs |
Deletes encryption snapshot test data and assertions. |
src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/SqlExceptionTests.cs |
Restores the Framework-only serialization test configuration. |
src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/SqlConnectionTests.cs |
Deletes tests for the removed connection property. |
src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/SqlConnectionEncryptionInfoTests.cs |
Deletes snapshot and enum contract tests. |
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlServerCertificateValidationErrors.cs |
Deletes the certificate-validation errors enum. |
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlException.cs |
Removes snapshot storage, property, and cloning support. |
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionEncryptionMode.cs |
Deletes the negotiated encryption-mode enum. |
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionEncryptionInfo.cs |
Deletes the encryption diagnostic snapshot type. |
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnection.cs |
Removes EncryptionInfo. |
src/Microsoft.Data.SqlClient/ref/Microsoft.Data.SqlClient.cs |
Removes matching public API declarations. |
src/Microsoft.Data.SqlClient/notsupported/Microsoft.Data.SqlClient.csproj |
Removes feature-specific GenAPI arguments. |
src/Microsoft.Data.SqlClient/notsupported/GenApiHeader.txt |
Deletes the nullable-annotation generation header. |
src/Microsoft.Data.SqlClient/notsupported/GenApiExcludeAttributes.txt |
Deletes the nullable-metadata exclusion list. |
doc/snippets/Microsoft.Data.SqlClient/SqlServerCertificateValidationErrors.xml |
Deletes validation-error enum documentation. |
doc/snippets/Microsoft.Data.SqlClient/SqlException.xml |
Removes exception EncryptionInfo documentation. |
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionEncryptionMode.xml |
Deletes negotiated encryption-mode documentation. |
doc/snippets/Microsoft.Data.SqlClient/SqlConnectionEncryptionInfo.xml |
Deletes snapshot API documentation. |
doc/snippets/Microsoft.Data.SqlClient/SqlConnection.xml |
Removes connection EncryptionInfo documentation. |
doc/design-notes/2353-connection-encryption-info.md |
Deletes the reverted feature’s design note. |
Review effort: Balanced
saurabh500
marked this pull request as ready for review
November 17, 2026 00:47
saurabh500
enabled auto-merge (squash)
November 17, 2026 00:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts #5037 by reverting squash commit
b99cd83297792dc2d139a1378f77707d481390d9.This is the exact inverse of the original 19-file change (5 insertions, 1,888 deletions). It removes the connection-encryption information types and
SqlConnection.EncryptionInfo/SqlException.EncryptionInfoproperties from the implementation and reference API, removes their documentation and tests, restores the prior exception serialization test, and reverses the associated unsupported-platform GenAPI changes.