Enable more tests to run on all 3 runtimes, part 13 #10635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
2 times, most recently
from
7e3f8f4 to
a45dafc
Compare
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
from
1fc2bd5 to
f728327
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
3 times, most recently
from
a6f8ea0 to
f802ad8
Compare
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
from
4a71530 to
e5a3fb0
Compare
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
from
e5a3fb0 to
d305b94
Compare
There was a problem hiding this comment.
Pull request overview
This pull request extends test coverage in InstallAndRunTests.cs by modifying test methods to run on all three Android runtimes (MonoVM, CoreCLR, and NativeAOT) instead of being limited to specific runtimes. The PR is part of a series (part 13) aimed at improving runtime test coverage.
Changes:
- Converted multiple test methods from [TestCase] attributes to [Values] attributes with AndroidRuntime parameter
- Added runtime-specific package name generation using
PackageUtils.MakePackageName(runtime) - Added
IgnoreUnsupportedConfigurationchecks and runtime-specificAssert.Ignorestatements for known limitations - Created test data generator methods
Get_DotNetRun_DataandGet_SmokeTestBuildAndRunWithSpecialCharacters_Datato generate test combinations
Comments suppressed due to low confidence (1)
tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs:448
- Condition is always false because of ... == ....
AndroidRuntime.CoreCLR => null, // CoreCLR explicitly passes a `null` sender
8e367d7 to
df8d7ca
Compare
… broken on NativeAOT
…locally It might work on CI, we'll see
It may be broken on CI with CoreCLR+FastDev
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
grendello
force-pushed
the
dev/grendel/test-runtimes-13
branch
from
fa9fd76 to
ffa9f47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.