[release/10.0] CreateServer with TestServerOptions in WebApplicationFactory #64809
+67
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @@github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #64803 to release/10.0
/cc @BrennanConroy @manandre
CreateServer with TestServerOptions in WebApplicationFactory
Description
We added an extension point for allowing users to customize the
TestServercreation which changed how theTestServerwas constructed. The new construction didn't flow theTestServerOptionsthrough.Fixes #64593
Customer Impact
Previous test code that was using
TestServerOptionsmight no longer have those options applied.Regression?
Regressed from 9.0
Risk
Small easy fix
Verification
Packaging changes reviewed?