Fixes hot reload of CRUD API data file. Closes #1390 #1484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the CRUD API plugin to enable hot reload of the data file by introducing a dedicated CrudApiDataLoader class that leverages the existing BaseLoader infrastructure with file watching capabilities. The changes separate concerns between API definition loading and data loading, allowing both to be independently monitored and reloaded.
Key changes:
- Introduced
CrudApiDataLoaderto handle data file loading with hot reload support - Renamed
_loaderto_definitionLoaderinCrudApiPluginfor clarity - Updated
BaseLoaderto skip schema validation for JSON arrays (data files)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| DevProxy.Plugins/Mocking/CrudApiPlugin.cs | Refactored to use separate loaders for API definition and data, removing inline LoadData() method |
| DevProxy.Plugins/Mocking/CrudApiDataLoader.cs | New loader class that extends BaseLoader to provide hot reload functionality for CRUD API data files |
| DevProxy.Abstractions/Plugins/BaseLoader.cs | Updated schema validation to skip JSON arrays, enabling validation of data files |
Co-authored-by: Copilot <[email protected]>
garrytrinder
approved these changes
Jan 6, 2026
Contributor
garrytrinder
left a comment
garrytrinder
left a comment
There was a problem hiding this comment.
Works like a charm. I tested changing data and changing actions, all worked perfectly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hot reload of CRUD API data file. Closes #1390