Resolve image authentication after dry run check in CopyImageService#1966
Merged
lbussell merged 1 commit intodotnet:mainfrom Feb 13, 2026
Merged
Resolve image authentication after dry run check in CopyImageService#1966lbussell merged 1 commit intodotnet:mainfrom
lbussell merged 1 commit intodotnet:mainfrom
Conversation
mthalman
approved these changes
Feb 13, 2026
lbussell
added a commit
to lbussell/docker-tools
that referenced
this pull request
Feb 18, 2026
Move GetRegistryResource calls after the dry-run early return so that dry-run mode does not require a populated PublishConfiguration. This fixes CopyBaseImages and CopyAcrImages failures in PR validation pipelines where appsettings.json is not generated. This fix was originally applied in dotnet#1966 but was inadvertently reverted by the logging migration in dotnet#1968. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lbussell
added a commit
that referenced
this pull request
Feb 19, 2026
PR #1966 fixed `CopyImageService.ImportImageAsync` to skip the `PublishConfiguration` lookup in dry-run mode. This fix was inadvertently reverted by the logging migration in #1968 due to a bad merge. 1. **Test** — Added `CopyImageServiceTests` with a test that exercises `ImportImageAsync` in dry-run mode with an empty `PublishConfiguration`, verifying it does not throw. 2. **Fix** — Moved `GetRegistryResource` calls and all Azure import logic after an early return for `isDryRun`, so dry-run mode only logs what would happen without requiring registry authentication details. Fixes pipeline failures in #1963. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PR failures in #1963