Use stronger warnings against tar/zip ExtractToDirectory - #55455
Open
rzikm wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request strengthens the guidance around using ZIP/TAR ExtractToDirectory convenience APIs by escalating the documentation from a note to explicit warnings, and by clarifying safer patterns for handling untrusted archives.
Changes:
- Tightens the streaming ZIP guidance to focus on per-entry extraction rather than whole-archive extraction.
- Replaces a NOTE with a WARNING to emphasize
ExtractToDirectorymust be used only with trusted inputs. - Adds a new WARNING about
TarReader.GetNextEntry(copyContents: true)potentially allocating large amounts of memory for untrusted archives.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/standard/io/zip-tar-best-practices.md | Strengthens warnings and clarifies safe patterns for trusted vs. untrusted archive extraction. |
| docs/standard/io/snippets/zip-tar-best-practices/csharp/Program.cs | Updates the TAR streaming snippet to demonstrate safer handling of entry data lifetimes and memory usage. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
gewarren
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhance warnings regarding the use of
ExtractToDirectoryfor ZIP and TAR archives to emphasize the importance of using these methods only with trusted inputs. Update documentation to clarify potential risks and provide safer alternatives for handling untrusted archives.Internal previews