Add docs for diagnostics related to tuple declarations - #55461
Merged
Conversation
Consolidate the additional errors and warnings related to tuple declarations.
Wordsmithing and style guide practices.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a consolidated documentation page for C# tuple-related diagnostics (tuple element names, metadata, conversions, equality, type inference, and tuple-related pattern matching), and updates navigation and redirects so older per-diagnostic pages continue to resolve correctly.
Changes:
- Added a new Tuple declarations compiler-messages page that documents the tuple-themed diagnostics in one place.
- Updated the C# language reference TOC and removed individual TOC entries for diagnostics that are now covered by the consolidated page.
- Added redirects for removed per-diagnostic pages, and removed those diagnostics from the “sorry we don’t have specifics” catch-all page.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/csharp/misc/sorry-we-don-t-have-specifics-on-this-csharp-error.md | Removes tuple-related diagnostic codes that are now documented elsewhere. |
| docs/csharp/language-reference/toc.yml | Adds a “Tuple declarations” node pointing to the new consolidated article, and removes individual TOC entries now covered by it. |
| docs/csharp/language-reference/compiler-messages/tuple-errors.md | New consolidated documentation page for tuple-related compiler errors and warnings. |
| docs/csharp/language-reference/compiler-messages/cs8210.md | Removes the standalone CS8210 page (now covered by tuple-errors.md via redirect). |
| docs/csharp/language-reference/compiler-messages/cs8141.md | Removes the standalone CS8141 page (now covered by tuple-errors.md via redirect). |
| docs/csharp/language-reference/compiler-messages/cs8140.md | Removes the standalone CS8140 page (now covered by tuple-errors.md via redirect). |
| docs/csharp/language-reference/compiler-messages/cs8139.md | Removes the standalone CS8139 page (now covered by tuple-errors.md via redirect). |
| docs/csharp/language-reference/compiler-messages/cs8127.md | Removes the standalone CS8127 page (now covered by tuple-errors.md via redirect). |
| docs/csharp/language-reference/compiler-messages/cs8125.md | Removes the standalone CS8125 page (now covered by tuple-errors.md via redirect). |
| docs/csharp/language-reference/compiler-messages/cs8124.md | Removes the standalone CS8124 page (now covered by tuple-errors.md via redirect). |
| .openpublishing.redirection.csharp.json | Adds redirects from removed per-diagnostic pages to the new consolidated tuple diagnostics page. |
Suppressed comments (1)
docs/csharp/language-reference/compiler-messages/tuple-errors.md:111
- The CS8179 message is missing a trailing period in the "ValueTuple infrastructure" section, but the same message includes a period in the earlier list at the top of the article. Make the punctuation consistent.
- **CS8128**: *Member 'member' was not found on type 'type' from assembly 'assembly'.*
- **CS8179**: *Predefined type 'type' is not defined or imported*
- **CS8182**: *Predefined type 'type' must be a struct.*
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Add periods as needed. Quote metadata.
BillWagner
marked this pull request as ready for review
August 17, 2026 20:46
gewarren
approved these changes
Aug 17, 2026
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
BillWagner
enabled auto-merge (squash)
August 18, 2026 14:53
gewarren
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55337
Add all diagnostic codes related to tuple declarations and use. These were added in C# 7.x
Internal previews