Skip to content

Add docs for diagnostics related to tuple declarations - #55461

Merged
BillWagner merged 7 commits into
dotnet:mainfrom
BillWagner:tuple-diagnostics
Aug 18, 2026
Merged

Add docs for diagnostics related to tuple declarations#55461
BillWagner merged 7 commits into
dotnet:mainfrom
BillWagner:tuple-diagnostics

Conversation

@BillWagner

@BillWagner BillWagner commented Aug 17, 2026

Copy link
Copy Markdown
Member

Consolidate the additional errors and warnings related to tuple declarations.
Wordsmithing and style guide practices.
Copilot AI lite review requested due to automatic review settings August 17, 2026 20:28
@dotnetrepoman dotnetrepoman Bot added this to the August 2026 milestone Aug 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a consolidated documentation page for C# tuple-related diagnostics (tuple element names, metadata, conversions, equality, type inference, and tuple-related pattern matching), and updates navigation and redirects so older per-diagnostic pages continue to resolve correctly.

Changes:

  • Added a new Tuple declarations compiler-messages page that documents the tuple-themed diagnostics in one place.
  • Updated the C# language reference TOC and removed individual TOC entries for diagnostics that are now covered by the consolidated page.
  • Added redirects for removed per-diagnostic pages, and removed those diagnostics from the “sorry we don’t have specifics” catch-all page.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
docs/csharp/misc/sorry-we-don-t-have-specifics-on-this-csharp-error.md Removes tuple-related diagnostic codes that are now documented elsewhere.
docs/csharp/language-reference/toc.yml Adds a “Tuple declarations” node pointing to the new consolidated article, and removes individual TOC entries now covered by it.
docs/csharp/language-reference/compiler-messages/tuple-errors.md New consolidated documentation page for tuple-related compiler errors and warnings.
docs/csharp/language-reference/compiler-messages/cs8210.md Removes the standalone CS8210 page (now covered by tuple-errors.md via redirect).
docs/csharp/language-reference/compiler-messages/cs8141.md Removes the standalone CS8141 page (now covered by tuple-errors.md via redirect).
docs/csharp/language-reference/compiler-messages/cs8140.md Removes the standalone CS8140 page (now covered by tuple-errors.md via redirect).
docs/csharp/language-reference/compiler-messages/cs8139.md Removes the standalone CS8139 page (now covered by tuple-errors.md via redirect).
docs/csharp/language-reference/compiler-messages/cs8127.md Removes the standalone CS8127 page (now covered by tuple-errors.md via redirect).
docs/csharp/language-reference/compiler-messages/cs8125.md Removes the standalone CS8125 page (now covered by tuple-errors.md via redirect).
docs/csharp/language-reference/compiler-messages/cs8124.md Removes the standalone CS8124 page (now covered by tuple-errors.md via redirect).
.openpublishing.redirection.csharp.json Adds redirects from removed per-diagnostic pages to the new consolidated tuple diagnostics page.
Suppressed comments (1)

docs/csharp/language-reference/compiler-messages/tuple-errors.md:111

  • The CS8179 message is missing a trailing period in the "ValueTuple infrastructure" section, but the same message includes a period in the earlier list at the top of the article. Make the punctuation consistent.
- **CS8128**: *Member 'member' was not found on type 'type' from assembly 'assembly'.*
- **CS8179**: *Predefined type 'type' is not defined or imported*
- **CS8182**: *Predefined type 'type' must be a struct.*

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/csharp/language-reference/compiler-messages/tuple-errors.md Outdated
Comment thread docs/csharp/language-reference/compiler-messages/tuple-errors.md Outdated
Add periods as needed. Quote metadata.
@BillWagner
BillWagner marked this pull request as ready for review August 17, 2026 20:46
@BillWagner
BillWagner requested a review from a team as a code owner August 17, 2026 20:46
Comment thread docs/csharp/language-reference/compiler-messages/tuple-errors.md Outdated
Comment thread docs/csharp/language-reference/compiler-messages/tuple-errors.md Outdated
Comment thread docs/csharp/language-reference/compiler-messages/tuple-errors.md Outdated
BillWagner and others added 2 commits August 18, 2026 10:47
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@BillWagner
BillWagner enabled auto-merge (squash) August 18, 2026 14:53
@BillWagner
BillWagner merged commit 0c32085 into dotnet:main Aug 18, 2026
10 checks passed
@BillWagner
BillWagner deleted the tuple-diagnostics branch August 19, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Diagnostics] - Tuples: names, metadata, conversions, and equality

3 participants