[release/10.0] Fix GO batch separator not recognized when block comment contains single quote

[Copilot]

Fixes #37494

Description

EF Core splits SQL Server migration scripts into batches on lines starting with GO. To avoid splitting inside string literals, SqlServerMigrationsSqlGenerator tracks whether it is inside a quoted string using a quoted boolean that toggles on single quotes ('). This quote-tracking logic was introduced in #34917.

The implementation does not handle standard SQL block comments (/* ... */). If a block comment contains a single quote, the quoted state is incorrectly toggled even though the quote is inside a comment. Since there is no matching closing quote, quoted remains true across subsequent lines. As a result, a later GO line is not recognized as a batch separator and is sent to SQL Server as literal text, causing:

Microsoft.Data.SqlClient.SqlException: Incorrect syntax near 'go'.

Customer impact

Customers using SQL migrations with stored procedures or other SQL scripts that include block comments containing single quotes will experience migration failures with "Incorrect syntax near 'go'" errors. This can occur when documentation comments in SQL scripts use contractions or possessives (e.g., "It's", "user's").

Workarounds:

• Remove single quotes from block comments
• Use two single quotes in block comments to escape them

How found

Customer reported on 10.0.1

Regression

Yes, from EF Core 9.0. Introduced in #34917.

Testing

Added 11 tests.

Risk

Medium. The changes only affect custom SQL operations in migrations.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• http://crl3.digicert.com:443/DigiCertTrustedG4RSA4096SHA256TimeStampingCA.crl
  • Triggering command: /usr/bin/dotnet dotnet build src/EFCore.SqlServer/EFCore.SqlServer.csproj --detach 6fe0.pid /run/containerd/io.containerd.runtime.v2.task/moby/17cb24c6361d5627f6d657f1cc3a5adae2b860e2c5b1dac8c18ee9896bc5302d/9de091e27e35a64e8a4e82cd61f3a4600691317ab977b24c24318149350413e6.pid 17cb24c6361d5627f6d657f1cc3a5adae2b860e2c5b1dac8c18ee9896bc5302d (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[AndriySvyryd]

@copilot Update progress by rewriting the PR summary using this template:

Fixes #{number}

**Description**
{Issue description}

**Customer impact**
{How does the reported issue affects customer's app? Are there workarounds?}

**How found**
{Was it customer reported or found during verification? How many customers are affected?}

**Regression**
{Is it a regression from a released version? Which one?}

**Testing**
{How the changes were tested}

**Risk**
{Low/Medium/High, argument why}

[Copilot]

@copilot Update progress by rewriting the PR summary using this template:

...

Done in 181fdd0. Updated PR description using the requested template format.

[Copilot]

Pull request overview

This PR fixes a bug in SQL Server migrations where GO batch separators were not recognized when block comments contained single quotes. The issue was introduced in EF Core 9.0 when quote-tracking logic was added, but it didn't account for block comments.

Changes:

• Replaces simple boolean quote tracking with a state machine that properly handles SQL strings, line comments, and block comments
• Adds comprehensive test coverage with 11 new test cases covering various comment and string scenarios

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/EFCore.SqlServer/Migrations/SqlServerMigrationsSqlGenerator.cs	Implements a state machine with 6 states (Normal, Quoted, InBlockComment, MaybeLineComment, MaybeBlockCommentStart, MaybeBlockCommentEnd) to correctly parse SQL and ignore quotes inside block comments
test/EFCore.SqlServer.FunctionalTests/Migrations/SqlServerMigrationsSqlGeneratorTest.cs	Adds 11 test cases covering block comments with quotes, multiline comments, empty comments, nested comments/strings, and edge cases like GO inside comments