-
Notifications
You must be signed in to change notification settings - Fork 841
Add optional keepAssemblyContents to ParseAndCheckInteraction #19155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dotnet-policy-service agree company="IntelliFactory" |
|
This would be binary breaking. Which is not bad by default, just so it's a concious decision. |
|
@vzarytovskii I'm happy to make it non-breaking with an overload or differently named method ( |
Overload is usually good enough, but it's up to @T-Gro, if breaking change is fine or not. |
❗ Release notes required
|
|
A sibling PR is removing switches for ML compat syntax anyway, so the upcoming FCS api will not be backwards compatible with the current one. |
T-Gro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes, this is good now @Jand42 .
Please add the release notes based on the instructions from the bot above 👍
Head branch was pushed to by a user without write access
Adding a new optional parameter
keepAssemblyContentstoFsiEvaluationSession.ParseAndCheckInteraction.This is a minor change that enables using an
fsisession and also doing full content analysis on entered interactions. I have used a local build of my changes to make a WebSharper-enabled interactive session.Question: would an overload be preferred instead of optional argument to keep binary compatibility? Or it's not a primary concern for FCS and code compatibility is enough?