Skip to content

Conversation

@Jand42
Copy link
Contributor

@Jand42 Jand42 commented Dec 12, 2025

Adding a new optional parameter keepAssemblyContents to FsiEvaluationSession.ParseAndCheckInteraction.

This is a minor change that enables using an fsi session and also doing full content analysis on entered interactions. I have used a local build of my changes to make a WebSharper-enabled interactive session.

Question: would an overload be preferred instead of optional argument to keep binary compatibility? Or it's not a primary concern for FCS and code compatibility is enough?

@Jand42
Copy link
Contributor Author

Jand42 commented Dec 12, 2025

@dotnet-policy-service agree company="IntelliFactory"

@vzarytovskii
Copy link
Member

This would be binary breaking. Which is not bad by default, just so it's a concious decision.

@Jand42
Copy link
Contributor Author

Jand42 commented Dec 15, 2025

@vzarytovskii I'm happy to make it non-breaking with an overload or differently named method (ParseAndCheckInteractionAndKeepAssemblyContents would be descriptive, but pretty long...). Please advise, thank you!

@vzarytovskii
Copy link
Member

@vzarytovskii I'm happy to make it non-breaking with an overload or differently named method (ParseAndCheckInteractionAndKeepAssemblyContents would be descriptive, but pretty long...). Please advise, thank you!

Overload is usually good enough, but it's up to @T-Gro, if breaking change is fine or not.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.200.md

@T-Gro
Copy link
Member

T-Gro commented Dec 15, 2025

A sibling PR is removing switches for ML compat syntax anyway, so the upcoming FCS api will not be backwards compatible with the current one.

Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, this is good now @Jand42 .
Please add the release notes based on the instructions from the bot above 👍

@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Jan 5, 2026
@T-Gro T-Gro enabled auto-merge (squash) January 5, 2026 11:04
auto-merge was automatically disabled January 5, 2026 11:11

Head branch was pushed to by a user without write access

@T-Gro T-Gro enabled auto-merge (squash) January 5, 2026 11:20
@T-Gro T-Gro merged commit 1cf6b9b into dotnet:main Jan 6, 2026
39 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants