[ci-fix] Needs review: Add RequiresProcessIsolation to ByRefLike/Validate.csproj for minifullaot (refs #128767)#129314
Draft
github-actions[bot] wants to merge 2 commits into
Draft
Conversation
…laot The test was failing in the minifullaot build because the merged test runner included Validate.cs but not the InvalidCSharp.ilproj reference (which is correctly excluded via DisableProjectBuild). Adding RequiresProcessIsolation ensures the project is built standalone, so DisableProjectBuild properly excludes it from the minifullaot build. This matches the pattern of the sibling ValidateNegative.csproj which already has RequiresProcessIsolation for the same reason. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #128767
Note
This is an AI/Copilot-generated best-effort fix attempt that I could not fully validate. It is a starting point for a maintainer, not a finished change. Please review the analysis below before merging.
Root cause (best analysis)
The
ByRefLike/Validate.csprojtest project hasMonoAotIncompatible=true, which should exclude it from the minifullaot build viaDisableProjectBuild. However, withoutRequiresProcessIsolation=true, the merged test runner assembly includesValidate.csandGenericTypeSubstitution.csas source files. The merged runner does NOT include theInvalidCSharp.ilprojProjectReference (which IS properly excluded byDisableProjectBuild), resulting in:This error occurs in "Building managed test group 3" of the minifullaot build.
Attempted fix
Added
<RequiresProcessIsolation>true</RequiresProcessIsolation>toValidate.csproj. This ensures the project is built as a standalone test (not merged into a group runner), soDisableProjectBuildproperly excludes it from the minifullaot build.This matches the exact pattern of the sibling
ValidateNegative.csprojwhich already has:What is unverified / where I need help
src/tests/build.sh -mono /p:RuntimeVariant=minifullaoton the Loader/classloader subtree would confirmValidation
src/tests/build.sh ci os linux x64 Release -mono /p:RuntimeVariant=minifullaot(builds test group 3 which includes this project)Evidence
Help wanted
area-VM-meta-mono):@steveisok,@dotnet/runtime-infrastructureFiled by
ci-failure-fix. Comment here or on the workflow file to suggest changes;ci-failure-scan-feedbackreads in-scope feedback daily and opens (or updates) a PR with prompt edits.Note
🔒 Integrity filter blocked 1 item
The following item was blocked because it doesn't meet the GitHub integrity level.
issue_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: