-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Update Orleans samples to 10.0.0 #7085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Orleans samples from various older versions (7.0, 8.0, 9.0) to Orleans 10.0.0 and .NET 10.0. The changes are comprehensive and include:
Changes:
- Updated all project target frameworks from net7.0/net8.0/net9.0 to net10.0
- Updated Orleans packages from versions 7.0.0/8.0.0/9.0.1 to 10.0.0
- Updated Microsoft.Extensions and third-party packages to their latest compatible versions
- Modernized timer registration from
RegisterTimertoRegisterGrainTimerwith new options pattern - Added nullable reference type annotations across many files
- Added convenience run.sh and run.cmd scripts for all samples
- Updated README documentation to reference .NET 10
- Consolidated Directory.Build.props files
- Updated Azure SDK usage patterns and MudBlazor component API calls
Reviewed changes
Copilot reviewed 171 out of 171 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple .csproj files | Updated TargetFramework to net10.0 and package versions to 10.0.0 |
| Multiple README.md files | Updated documentation to reference .NET 10 SDK |
| Timer-related files | Migrated from RegisterTimer to RegisterGrainTimer with GrainTimerCreationOptions |
| run.sh/run.cmd files | Added new convenience scripts for running samples |
| Directory.Build.props | Consolidated common properties using MSBuild imports |
| Blazor components | Updated MudBlazor API calls to match newer versions |
| Azure integration | Updated TableServiceClient initialization patterns |
| Streaming samples | Added fallback to in-memory streaming when Azure secrets unavailable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <MudTd> | ||
| <MudFab Disabled=@(IsInCart?.Invoke(product) ?? false) Size=Size.Small | ||
| Color=Color.Primary Icon=@Icons.Material.Filled.AddShoppingCart | ||
| Color=Color.Primary StartIcon=@Icons.Material.Filled.AddShoppingCart |
Copilot
AI
Jan 21, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Icon attribute on MudFab has been changed to StartIcon. However, according to MudBlazor documentation, MudFab uses the Icon property (not StartIcon which is for buttons with text). This change may cause the icon to not display correctly or result in a compilation error.
| app.UseAntiforgery(); | ||
|
|
||
| app.MapStaticAssets(); | ||
| app.UseStaticFiles(); |
Copilot
AI
Jan 21, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MapStaticAssets() method has been replaced with UseStaticFiles(). However, MapStaticAssets() in .NET 9+ provides fingerprinting and optimization features that UseStaticFiles() does not. This change may impact asset caching and performance. Consider if this rollback to UseStaticFiles() is intentional for .NET 10.
| app.UseStaticFiles(); | |
| app.MapStaticAssets(); |
As the title suggests, this PR updates the Orleans samples to Orleans 10.0 and .NET 10.0