Added unit test coverage for VisualStylesMode rendering scenarios in NumericUpDown and Button controls. - #14899
Open
abineshPalanisamy wants to merge 1 commit into
Open
Conversation
Added unit test cases for the Fix_Issue_4212
Member
|
Could you take a look why the tests fail? |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds rendering smoke tests for Button and NumericUpDown across Classic and .NET 11 visual-style modes.
Changes:
- Tests normal, disabled, read-only, and flat-style rendering.
- Tests
NumericUpDowninvalidation and AutoSize layout behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ButtonVisualStylesTests.cs |
Adds Button rendering scenarios. |
NumericUpDownTests.cs |
Adds rendering and mode-change tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+950
to
+955
| Size sizeBeforeChange = numericUpDown.Size; | ||
|
|
||
| numericUpDown.VisualStylesMode = VisualStylesMode.Net11; | ||
|
|
||
| // Size may change due to different rendering in modern visual styles | ||
| Assert.NotNull(numericUpDown.Size); |
Comment on lines
+1473
to
+1474
| [InlineData(VisualStylesMode.Net11)] | ||
| [InlineData(VisualStylesMode.Classic)] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4212
Proposed changes
NumericUpDownwithVisualStylesMode.Net11andVisualStylesMode.Classic.ButtonwithVisualStylesMode.Net11andVisualStylesMode.Classic.NumericUpDown.VisualStylesModeinvalidates the control and triggers layout updates.DrawToBitmapwithout exceptions when visual styles are disabled.Customer Impact
Regression?
Risk
Test methodology
NumericUpDown.Button.Test environment(s)
Microsoft Reviewers: Open in CodeFlow