-
-
Notifications
You must be signed in to change notification settings - Fork 368
chore(Dependence): update denpendence package version #7395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- The PR title and commit message contain a typo (“Dependence/denpendence”); consider correcting to “dependency” for clarity and consistency in the history.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR title and commit message contain a typo (“Dependence/denpendence”); consider correcting to “dependency” for clarity and consistency in the history.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes incorrect version references for dependency packages in the .NET 6.0 and 7.0 target framework sections. Previously, these sections were incorrectly referencing NET8Version for several Microsoft.Extensions packages, and this PR corrects them to use the appropriate version variables for their respective frameworks.
Key Changes:
- Corrected NET6 dependency version references from
NET8VersiontoNET6Version - Corrected NET7 dependency version references from
NET8VersiontoNET7Version - Changed
NET10Versionfrom wildcard pattern to specific version "10.0.0"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <NET8Version>8.0.*</NET8Version> | ||
| <NET9Version>9.0.*</NET9Version> | ||
| <NET10Version>10.0.*</NET10Version> | ||
| <NET10Version>10.0.0</NET10Version> |
Copilot
AI
Dec 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The NET10Version property uses a specific version "10.0.0" while all other .NET version properties (NET6Version through NET9Version) use the wildcard pattern ".0.". For consistency with the established pattern in this file, consider changing this to "10.0.*" to match the format used for NET6-9 versions.
| <NET10Version>10.0.0</NET10Version> | |
| <NET10Version>10.0.*</NET10Version> |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7395 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 748 748
Lines 32793 32793
Branches 4551 4551
=========================================
Hits 32793 32793
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7394
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Chores: