Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Dec 23, 2025

Link issues

fixes #7394

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Chores:

  • Align dependency package versions in the shared build configuration file.

Copilot AI review requested due to automatic review settings December 23, 2025 01:04
@bb-auto bb-auto bot added the chore This are tasks or bot action label Dec 23, 2025
@bb-auto bb-auto bot added this to the v10.1.0 milestone Dec 23, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 23, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 766081e into main Dec 23, 2025
7 of 8 checks passed
@ArgoZhang ArgoZhang deleted the chore-version branch December 23, 2025 01:04
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The PR title and commit message contain a typo (“Dependence/denpendence”); consider correcting to “dependency” for clarity and consistency in the history.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The PR title and commit message contain a typo (“Dependence/denpendence”); consider correcting to “dependency” for clarity and consistency in the history.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes incorrect version references for dependency packages in the .NET 6.0 and 7.0 target framework sections. Previously, these sections were incorrectly referencing NET8Version for several Microsoft.Extensions packages, and this PR corrects them to use the appropriate version variables for their respective frameworks.

Key Changes:

  • Corrected NET6 dependency version references from NET8Version to NET6Version
  • Corrected NET7 dependency version references from NET8Version to NET7Version
  • Changed NET10Version from wildcard pattern to specific version "10.0.0"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<NET8Version>8.0.*</NET8Version>
<NET9Version>9.0.*</NET9Version>
<NET10Version>10.0.*</NET10Version>
<NET10Version>10.0.0</NET10Version>
Copy link

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NET10Version property uses a specific version "10.0.0" while all other .NET version properties (NET6Version through NET9Version) use the wildcard pattern ".0.". For consistency with the established pattern in this file, consider changing this to "10.0.*" to match the format used for NET6-9 versions.

Suggested change
<NET10Version>10.0.0</NET10Version>
<NET10Version>10.0.*</NET10Version>

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (799d0b2) to head (6e1aac6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7395   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          748       748           
  Lines        32793     32793           
  Branches      4551      4551           
=========================================
  Hits         32793     32793           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This are tasks or bot action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(Dependence): update denpendence package version

2 participants