refactor(types): add tests and linting#154
Closed
fdebijl wants to merge 3 commits intodraftbit:masterfrom
Closed
Conversation
Contributor
|
💯 this is great! once these tests pass I'll merge this in :) |
Collaborator
Author
Collaborator
Author
|
Closing this for now to keep my PR overview clean, feel free to re-open once this package is being worked on again 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some much needed quality control to the types by adding tests, a linter and automatic checks on each PR.
Full changelog:
This file contains code that is not meant to be ran, but is used by dtslint to check for any errors in the types
This runs the tests, lint and dtslint on any pull request