Repository navigation
Conversation
|
Also fixes #57 (and adds tests for this case). |
|
Tested this on a BGYM DD05 walking pad (BLE module FitShow FS-BT-F5, fw V1.0.5beta) through an ESPHome BT proxy. It's the same class of problem: the treadmill sends Training Status with reserved flag bits 0x46 and a reserved status code 83 (0x53), sometimes followed by a text payload. On pyftms 0.4.10 / 0.4.15 main, With this branch, One small issue: the pseudo-member returned by obj._value_ = masked
obj._name_ = Nonefixes it ( I've been running an equivalent workaround on the DD05 since 2026-11-14 (mask to |
|
Thanks @piyopiyolee for testing this on your DD05 and spotting the missing I reproduced the formatting failure on Python 3.13 and 3.14. Your suggested Updated PR #60 and published:
I reviewed your workaround notes as well. The parser changes here and the dynamic sensor options in dudanov/hassio-ftms#52 cover the reported reserved values. Could you share a sanitized raw notification that still requires skipping, especially one carrying text? That would help us add a precise regression test for any remaining case. |
|
Thanks @michaelw for the fix and the new tests! I ran debug captures on the BGYM DD05 tonight: two sessions started from the treadmill's physical remote and one started from Home Assistant. In every session the Training Status notifications decoded cleanly as PRE_WORKOUT (14), then MANUAL_MODE (13), then IDLE (1) on both pause and stop. None of them carried a text string, and nothing needed to be skipped. So I can't provide a text-carrying sample from this device; the skip in my local workaround was purely defensive. Happy to test FTMS v0.24.6+mw.10 on the DD05 if that helps. |
|
Correction to my comment above: I missed this in my earlier test. Digging further into the logs, the DD05 does send a text-carrying Training Status, just not in notifications. It shows up in the initial read when the connection is set up, every time: |
Update Python version requirements to support 3.14.
Implement handling for unknown and reserved values in TrainingStatusFlags and TrainingStatusCode with appropriate logging.
Address repeated disconnect callbacks to prevent errors.