Repository navigation
Conversation
|
Security source PASS for exact f069b11, scoped to the four-file stopped-path boundary repair. The repository root and wrapper state are mounted read-only; writable overlays are a closed list of application dependency/cache/storage/environment data, isolated PHP scaffold data and disposable public snapshots. The launcher refuses non-absolute/noncanonical/comma/newline paths, direct and intermediate symlinks, non-directory overlays and source/state containment before Docker; PHP TMPDIR no longer inherits host command-input storage. The wrapper, Git metadata, action verifier and trust inputs remain read-only, while Python/Rust scaffold roots are created but not exposed writable to PHP. The fake-Docker contracts cover the complete mount and environment sets without running a container. This verdict authorizes no real container or application/TLS execution and does not lift the existing stop. It does not qualify the image, installed dependencies, onboarding candidate or held #344 operation; those gates remain separate. |
|
Security/source review PASS for exact The four-file change establishes the requested host/container boundary:
I independently ran the exact-head fake-Docker/import-isolation suite (11/11), shell syntax, Python compilation, and This verdict does not authorize or claim a real container, package/app/TLS runtime, marker replacement, onboarding/activation, the frozen #338 candidate, or the stopped #344 operation. Those remain separate gates. |
The PHP CI launcher currently exposes its checkout and host-wrapper state read-write to package/application processes. This source change mounts both trees read-only and grants writes only to named application data, caches, dependency directories and PHP scaffold data. Host Python/Rust source and host temporary command inputs retain read-only exposure; PHP uses its own temporary-data directory.
The existing app writes are preserved through specific vendor/cache/storage/.env mounts. Preview tests use disposable public-directory snapshots so their hot-file writes do not expose checkout scripts/assets. Data mount paths must be canonical, non-symlink paths with disjoint source/control roots. The setup script prepares the PHP temporary directory, and the existing TLS fixture uses that declared data location.
Both PHP minors, current caller commands, immutable image binding, credential/environment allowlist, CA/PHAR verification, fixed-APT build inputs and limits are retained. No workflow or shared admission-policy record changes are included.
Source checks: shell syntax, Python AST parsing, seven explicit command-construction contracts using fake Docker/Git commands, public-boundary, whitespace and changed-source credential/private-path scans pass. The contracts construct and inspect arguments in disposable fixture directories; no actual Docker object, PHP/Composer/package/application code or runtime probe ran.
Draft / source-only. Caller CI is skipped. The stopped container-boundary validation and marker replacement probes were not executed, retried, copied or wired into setup. Existing old WIP is retained separately. No package/app/installed/onboarding qualification, replacement caller admission, merge or publication is authorized by these checks or by source review. Those explicit stops and the frozen #339 candidate
2bf6f2aremain.Refs #344. Independent Security source review passed for exact
f069b118886f922e979d865d964ed5179b9bc3dcand this four-file defensive diff. The source review is complete. This PR remains frozen and draft because the existing execution/admission stop still applies. It does not close #344 or establish runtime acceptance.