feat: Cursor workspaceOpen/failClosed + skill frontmatter, Factory hook cleanup, DeepAgents input.required#1774
Merged
Merged
Conversation
…ok cleanup, DeepAgents input.required Batch follow-up of three maintainer-scrap upstream issues: #1688 (Cursor): add the workspaceOpen hook event (canonical union + CURSOR_HOOK_EVENTS + mapping); add an optional failClosed field to HookDefinitionSchema and pass it through the Cursor hook adapter; add a cursor skill frontmatter section (paths, disable-model-invocation, metadata) emitted/round-tripped by CursorSkill. #1690 (Factory Droid): remove the stale setup/permissionRequest hook events from FACTORYDROID_HOOK_EVENTS and the mapping — they are not valid Droid events (confirmed 9-event set), so rulesync no longer emits dead keys. (Native droids/skills, global scope, hooks-file relocation, and permissions remain follow-ups.) #1689 (DeepAgents): map the canonical notification event to dcode's input.required (human-in-the-loop interrupt). (The directory-per-subagent .deepagents/agents/<name>/AGENTS.md layout remains a follow-up.) Closes #1688 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 8, 2026
Closed
Resolve conflicts from upstream Goose hooks (#1770) and Agent Skills (#1775): - src/types/hooks.ts: keep both new HookEvent members (workspaceOpen + messageDisplay) - src/features/skills/rulesync-skill.ts: keep both new skill sections (cursor + agentsskills) in schema and input type - docs/reference/file-formats.md: merge the hook matrix to 16 columns (incl. Goose), re-applying #1774's changes (workspaceOpen row, deepagents notification, Factory Droid permissionRequest/setup cleanup) on top of the upstream messageDisplay row; regenerate skills/rulesync/file-formats.md via the docs sync script Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
dyoshikawa
pushed a commit
that referenced
this pull request
Jun 9, 2026
Re-resolve rulesync-skill.ts after Cursor skill frontmatter (#1774) landed: keep all three skill sections (rovodev + cursor + agentsskills) in both the zod schema and the input type. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch follow-up of three
maintainer-scrapupstream issues, all primary-source verified.#1688 — Cursor:
workspaceOpenhook,failClosedfield, skill frontmatter (fully resolved)workspaceOpenhook event — added to the canonicalHookEventunion,CURSOR_HOOK_EVENTS, and the Cursor name mapping.failClosedfield — added an optionalfailClosedboolean toHookDefinitionSchema(block the action when the hook errors) and passed it through the Cursor hook adapter.cursorskill section (paths,disable-model-invocation,metadata) emitted and round-tripped byCursorSkill.#1690 — Factory Droid: remove stale hook events (partial)
FACTORYDROID_HOOK_EVENTSand the canonical→Factory mapping includedsetup→SetupandpermissionRequest→PermissionRequest, neither of which is a valid Droid event (the documented set is exactly 9: PreToolUse, PostToolUse, UserPromptSubmit, Notification, Stop, SubagentStop, PreCompact, SessionStart, SessionEnd). Removed them so rulesync no longer emits dead keys that Droid ignores.#1689 — DeepAgents:
input.requiredhook event (partial)Mapped the canonical
notificationevent todeepagents-code(dcode)input.required(human-in-the-loop interrupt) — the closest documented equivalent — and added it toDEEPAGENTS_HOOK_EVENTS.Validation evidence (primary sources)
workspaceOpen+failClosed: https://cursor.com/docs/hooks ; skill frontmatter: https://cursor.com/docs/skillsinput.required: https://docs.langchain.com/oss/python/deepagents/cli/configurationTest plan
pnpm cicheck— green (fmt, oxlint, typecheck, 5994 unit tests, sync-skill-docs, cspell, secretlint).workspaceOpen/failClosedemission; Cursor skillpaths/disable-model-invocation/metadataround-trip; Factory Droid dropssetup/permissionRequest; DeepAgentsnotification→input.required.e2e-hooks+e2e-skillspass in full (Tool × Feature happy-path preserved).Linked issues
workspaceOpenhook,failClosed, and skill frontmatter #1688input.requiredhook #1689 (input.required hook only)🤖 Generated with Claude Code