BR: Fix GC blkID race causing stale CORRUPTED data#416
Merged
Conversation
xiaoxichen
reviewed
May 29, 2026
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable/v4.x #416 +/- ##
==============================================
Coverage ? 53.36%
==============================================
Files ? 36
Lines ? 5350
Branches ? 670
==============================================
Hits ? 2855
Misses ? 2198
Partials ? 297 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
During PG snapshot, PGBlobIterator captures blob pbas in cur_blob_list_. If GC runs before the actual reads, all blobs in the shard are moved to new blkIDs, causing verify_blob to fail and incorrectly marking blobs as CORRUPTED with invalid stale data. Add an infinite recursive loop to load_blob_data to re-read the latest index and reload if blkID changes to ensure we get the correct data.
Collaborator
|
LGTM. pls rebase this PR and update conan version |
JacksonYao287
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During PG snapshot, PGBlobIterator captures blob pbas in cur_blob_list_. If GC runs before the actual reads, all blobs in the shard are moved to new blkIDs, causing verify_blob to fail and incorrectly marking blobs as CORRUPTED with invalid stale data.
Fix:
on verify_blob failure, re-check the index table. If pbas changed, signal STALE_BLKID, refresh the entire shard's blob list, and trigger NuRaft resend.Add an infinite recursive loop to load_blob_data to re-read the latest index and reload if blkID changes to ensure we get the correct data.