Skip to content

Edit output path to root instead of bin folder#11

Open
KevinLamb wants to merge 3 commits into
ebenso:masterfrom
KevinLamb:fix/output-path
Open

Edit output path to root instead of bin folder#11
KevinLamb wants to merge 3 commits into
ebenso:masterfrom
KevinLamb:fix/output-path

Conversation

@KevinLamb

@KevinLamb KevinLamb commented Jun 22, 2018

Copy link
Copy Markdown

Couldn't run due to an error on line 34 of WordPOSTagger.cs related to the ModelPath being set with AppDomain.CurrentDomain.BaseDirectory. AppDomain.CurrentDomain.BaseDirectory was returning the bin folder instead of the application root.

Edit: I plan on trying out a couple loggers after this.

@rohitshubham

Copy link
Copy Markdown
Member

Perfect! Thanks for taking a look at this. I plan on going through this change at some point over this weekend. 👍

@eigenharsha eigenharsha added the bug Something isn't working label Jun 24, 2018
@eigenharsha

eigenharsha commented Jun 24, 2018

Copy link
Copy Markdown
Member

@KevinLamb Thanks for looking into this, We can try to stay with the default .Net configuration structure, it will ease to other developers, they will get a solution to the output directory as default.

$(SolutionDir)bin\Debug or $(SolutionDir)bin\Release

For path issue, can we go through other options?

AppDomain.BaseDirectory Property

@KevinLamb

Copy link
Copy Markdown
Author

@eigenharsha Yep, that makes sense. I made another commit that simply changed the ModelPath variables to point two directories up. If it's planned that this gets used in ASP.NET apps then we'd need to change it. AppDomain.CurrentDomain.BaseDirectory returns the root folder instead of the Debug or Release folder for ASP.NET applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants