Solving IDL generator with structs inheritance which identifiers are Python keywords#174
Solving IDL generator with structs inheritance which identifiers are Python keywords#174Bit-Seq wants to merge 3 commits intoeclipse-cyclonedds:masterfrom
Conversation
|
Thanks @Bit-Seq! I think this change is okay, we are just having some CI troubles right now. I'll rerun when that is resolved and come back to this PR. |
|
Struct inheritance tests are in https://github.com/javiersorianoruiz/cyclonedds-python-checkReservedKeyword/tree/master/tests/. All the |
|
Hello! Have you been able to solve CI troubles? We (@jordialexalar and me) have created tests related to reserved Python keywords support using pytest. For a mistake we have added this file in the same fork as the pull requests pending to merge. All pull requests are connected, and also with the issues #105, #162, #163, #172 and #173. Sorry for the inconvenience. If there is any problem we can create another fork and pull request with the tests. Regards. |
|
I was discussing the status of this PR with @noxpardalis and triggered a custom run of the CI for this PR to confirm that all is well with #176 merged, but it turns out there is some problem: https://dev.azure.com/eclipse-cyclonedds/cyclonedds-python/_build/results?buildId=3867&view=results . The results of this run are not visible on GitHub because, well, reasons, but if I am not mistaken I started it the right way. I haven't looked at all the failures, but my sample suggests it consistently fails in the On a side note: if the test run were successful, merging it would still be blocked anyway on the Eclipse Contributor Agreement verification. |
|
Cat on keyboard 😂 |
Solved the error detailed on #173.