[GTK4] Fix CTabFolder chevron click GTK-Critical #2940
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error is like: ``` (SWT:339274): Gtk-CRITICAL **: 17:08:42.533: gtk_widget_compute_point: assertion 'GTK_IS_WIDGET (widget)' failed ``` The problem comes from Control.getSurfaceOrigin method relying on fixedHandle to translate coordinated but not every widget has such, use eventHandle() instead. Tested with Snippet165.
Contributor
Test Results (linux) 84 files - 4 84 suites - 4 14m 10s ⏱️ -5s For more details on these failures, see this check. Results for commit cc1e8b8. ± Comparison against base commit cf7f9db. |
Member
Author
|
This is kind of prereq for #2895 as it fails for chevron button positioning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error is like:
The problem comes from Control.getSurfaceOrigin method relying on fixedHandle to translate coordinated but not every widget has such, use eventHandle() instead.
Tested with Snippet165.