Use OfFloat Point values to create precise highlight brackets

[ShahzaibIbrahim]

Because of rounding errors the bracket selection highlight is often inconsistent. Making use of residual values provides precise rectangle values and highlight is consistent across all zooms

Problem # 1: At 125% the highlight height is too small. Almost touching the bracket

Problem # 2: At 250% (the problem is also there for all zooms, at 250 its just better visible), After every three line the fourth line x axis is bit too much on the left. (rounding error)

line 29: the width of highlight is 17px

line 30: the width of highlight is 16px

How to test

• Run the runtime workspace with monitor-specific scaling turned on
• Add some brackets in Java file { }
• Select the opening bracket, the closing bracket will be highlighted.
• See if the rectangle around highlighted bracket is surrounded the bracket correctly (no-cutoffs)

Result

Before Fix:

After Fix:

Requires:

• Add Rectangle.of(Point,Point) supporting OfFloat eclipse.platform.swt#2907

[github-actions]

Test Results

 3 015 files  ±0   3 015 suites  ±0   2h 9m 3s ⏱️ - 6m 54s
 8 258 tests ±0   8 010 ✅ ±0  248 💤 ±0  0 ❌ ±0 
23 598 runs  ±0  22 807 ✅ ±0  791 💤 ±0  0 ❌ ±0 

Results for commit a309909. ± Comparison against base commit 93acda3.

♻️ This comment has been updated with latest results.

[HeikoKlare]

Is it intended that with removing the -1 from the height calculation, the highlight is now too high and exceeds the line?

Before: