Remove the leftover SAC references after the value-record migration#4143
Merged
Conversation
Follow-up to 5a8b668, which deleted the tkuiTestsToRefactor legacy sources but left Import-Package: org.w3c.css.sac in the org.eclipse.e4.ui.tests.css.swt manifest, plus stale SAC/Batik mentions in two css.core Javadoc comments. Nothing on the build path uses SAC anymore, so drop the import and rewrite the comments. The org.w3c.css.sac library can now leave the target platform once no bundle outside this repo needs it.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4139, which deleted the
tkuiTestsToRefactorlegacy tests but left two SAC traces behind: theImport-Package: org.w3c.css.sacin theorg.eclipse.e4.ui.tests.css.swtmanifest, and a handful ofSAC/Batik mentions in CSS-core and test comments.Nothing on the build path uses SAC anymore, so this drops the import and rewrites the comments (keeping the behavioral rationale, just without the SAC name). With this in, the repo has no remaining reference to
org.w3c.css.sac, so the library can leave the target platform once no bundle outside this repo needs it.