HTTP client clean fixes - #6269
Open
vietj wants to merge 6 commits into
Open
Conversation
vietj
commented
Jul 31, 2026
vietj
commented
Member
- Fix shared HTTP client implementation.
- Unify HttpClientBuilderInternal client creation between the shared / non shared cases.
- Add a failing test.
Motivation: The shared HTTP client has a regression where closing one of its client, will close the underlying client. Changes: Improve the shared resource API to reuse the contract introduced by the cleanable resource, to be used instead of the closeable future. In order to properly support shared client with shutdown timeout we need a contract that supports it, this is already provided by the cleanable resource contract. As consequence, the cleanable resource used by the cleanable HTTP client, can be the shared resource that now comes as a cleanable resource.
…non shared cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.