Angular Material: Remove EnumOption[] type from AutocompleteControlRenderer.options#2550
Open
daniel-shuy wants to merge 1 commit intoeclipsesource:masterfrom
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sdirix
reviewed
Mar 5, 2026
Member
sdirix
left a comment
sdirix
left a comment
There was a problem hiding this comment.
I don't fully understand. Why should we not allow the users to pass their own non-matching label/value pairs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2535, I changed
AutocompleteControlRenderer.optionsfromstring[]toEnumOption[] | string[], then mapped theEnumOption[] | string[]toEnumOption[], which was the type of the internaloptionsprop, using thestringOptionsToEnumOptionsfunction.This allowed users of the
AutocompleteControlRendererto passEnumOptions with differinglabelandvalue, which should not be allowed.