Skip to content

refactor: move IDE selection to inline dropdown in Folder view (#1254)#1261

Merged
fengju0213 merged 4 commits intoeigent-ai:mainfrom
eureka0928:refactor/open-agent-folder-workflow
Feb 25, 2026
Merged

refactor: move IDE selection to inline dropdown in Folder view (#1254)#1261
fengju0213 merged 4 commits intoeigent-ai:mainfrom
eureka0928:refactor/open-agent-folder-workflow

Conversation

@eureka0928
Copy link
Copy Markdown
Contributor

@eureka0928 eureka0928 commented Feb 13, 2026 •
edited
Loading

Related Issue

Closes #1254

Description

The "Open in IDE" feature (PR #1159) currently splits the action across two disconnected places: a "Preferred IDE" dropdown in Settings → General and a terminal icon button in the Folder view header. This is hard to discover and adds unnecessary friction.

This PR moves IDE selection to the point of action by replacing the single icon button with an inline DropdownMenu that offers three options directly: "Open in VS Code", "Open in Cursor", and "Open in File Manager". The last choice is remembered via authStore.setPreferredIDE(). The now-redundant Settings section is removed.

Key Changes:

src/components/Folder/index.tsx:

  • Replaced the single <Button> with a <DropdownMenu> using the same terminal icon as trigger
  • Extracted inline onClick handler into handleOpenInIDE(ide) function
  • 3 menu items each immediately open the folder with the selected IDE
  • On success, persists the choice via authStore.setPreferredIDE(ide)

src/pages/Setting/General.tsx:

  • Removed the entire "Preferred IDE" settings card (Select dropdown with VS Code / Cursor / System File Manager)

src/i18n/locales/*/chat.json (11 locales):

  • Added open-in-vscode, open-in-cursor, open-in-file-manager keys with translations

src/i18n/locales/*/setting.json (11 locales):

  • Removed obsolete preferred-ide, preferred-ide-description, system-file-manager keys

No changes needed:

  • src/store/authStore.ts — preferredIDE + persistence kept (still used to remember last choice)
  • electron/main/index.ts — IPC handlers unchanged
  • electron/preload/index.ts — Preload bridge unchanged

Testing Evidence (REQUIRED)

  • I have included human-verified testing evidence in this PR.
  • This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
  • No frontend/UI changes in this PR.
image image

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Contribution Guidelines Acknowledgement

@bytecii
Copy link
Copy Markdown
Collaborator

bytecii commented Feb 13, 2026

Can you add a short video or snapshot for your PR? Thanks.

@eureka0928
refactor: replace IDE button with inline DropdownMenu in Folder view
623213a 
Move IDE selection to the point of action via a dropdown menu on the
terminal icon button, offering "Open in VS Code", "Open in Cursor",
and "Open in File Manager" options. Remembers last choice via authStore.
@eureka0928
refactor: remove Preferred IDE section from Settings General page
6a36095 
The IDE selection is now handled inline in the Folder view dropdown,
making this settings section redundant.
@eureka0928
refactor: update i18n keys for inline IDE dropdown
864752b 
Add open-in-vscode, open-in-cursor, open-in-file-manager keys to
chat.json across all 11 locales. Remove obsolete preferred-ide,
preferred-ide-description, and system-file-manager keys from setting.json.
@eureka0928 eureka0928 force-pushed the refactor/open-agent-folder-workflow branch from ab87764 to 864752b Compare February 18, 2026 22:01
@eureka0928
Copy link
Copy Markdown
Contributor Author

eureka0928 commented Feb 18, 2026

@Pakchoioioi @bytecii please review the screenshots, I attached

@eureka0928
Copy link
Copy Markdown
Contributor Author

eureka0928 commented Feb 20, 2026

Hi @Douglasymlai would you review this PR?
Thank you

@Wendong-Fan Wendong-Fan added this to the Sprint 16 milestone Feb 21, 2026
@Wendong-Fan
Copy link
Copy Markdown
Contributor

Wendong-Fan commented Feb 21, 2026

thanks @eureka928 for the contribution and sorry for the late reply, could @4pmtong and @fengju0213 help reviewing this?

@eureka0928
Copy link
Copy Markdown
Contributor Author

eureka0928 commented Feb 24, 2026

I'd like to follow up on this

@eureka0928
Copy link
Copy Markdown
Contributor Author

eureka0928 commented Feb 24, 2026

Hi @Douglasymlai @a7m-1st would you review this PR as well?
Thank you

Douglasymlai
Douglasymlai approved these changes Feb 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Douglasymlai Douglasymlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eureka928 Thanks for contributing. Feature function testing passed. There are no conflicts. There are still some space for UX improvement but we can merge this PR first. @4pmtong Can you help run the final review for the code before merging?

@eureka0928
Copy link
Copy Markdown
Contributor Author

eureka0928 commented Feb 24, 2026

@Douglasymlai thank you for your review
Would you create following issue so that I can put the PR?

fengju0213
fengju0213 approved these changes Feb 25, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fengju0213 fengju0213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good thanks ！@eureka928

@fengju0213 fengju0213 merged commit b64c2d2 into eigent-ai:main Feb 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Douglasymlai Douglasymlai Douglasymlai approved these changes

@fengju0213 fengju0213 fengju0213 approved these changes

@4pmtong 4pmtong Awaiting requested review from 4pmtong

Assignees

@eureka0928 eureka0928

Labels

frontend Review Required

Projects

None yet

Milestone

Sprint 16

Development

Successfully merging this pull request may close these issues.

[Feature Request] Refactor "Open Agent Folder" workflow

5 participants

@eureka0928 @bytecii @Wendong-Fan @Douglasymlai @fengju0213