-
Notifications
You must be signed in to change notification settings - Fork 300
chore: Add AGENTS.md file for sync-service #3735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds a new documentation file for the Electric Sync Service (Elixir) detailing scope, goals, related components, major subsystems, data flow, development commands, project layout, environment/dev settings, testing guidance, boundaries, cross-package APIs, and security/ops notes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
✏️ Tip: You can disable this entire section by setting Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/sync-service/AGENTS.md`:
- Around line 89-93: Add the missing ignore patterns to the sync-service package
.gitignore: open the packages/sync-service/.gitignore and append the two lines
"/log/" and "node_modules/" so the package-level rules match the Boundaries
documentation; ensure they are on their own lines and saved to commit.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
packages/sync-service/AGENTS.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: Build and typecheck packages/start
- GitHub Check: Build and typecheck packages/typescript-client
- GitHub Check: Build and typecheck packages/experimental
- GitHub Check: Build and typecheck packages/react-hooks
- GitHub Check: ensure_sync_service_image / build_image
- GitHub Check: Run Lux integration tests
🔇 Additional comments (8)
packages/sync-service/AGENTS.md (8)
8-12: Clear service description.The description accurately conveys the core purpose and scope of the Electric Sync Service.
81-87: Good Elixir testing pattern example.The code example demonstrates proper pattern matching in assertions, which is idiomatic Elixir. The syntax is correct and the guidance is valuable for maintaining consistent test style.
6-6: The referenced../../AGENTS.mdfile exists at the repository root.
14-28: All referenced subsystem directories exist and the documentation is accurate.
54-58: All services and ports documented indev/docker-compose.ymlare correctly configured: postgres (54321), postgres2 (54322), pgbouncer (65432), and nginx (3002) all exist with accurate port mappings as stated.
42-52: All project map paths are correct and exist. Verification confirms all 8 directories and files referenced in the project map (lib/electric/plug/, lib/electric/replication/, lib/electric/shapes/, lib/electric/shape_cache/, lib/electric/telemetry/, lib/pg_interop/, config/runtime.exs, and dev/) are present and accurately listed.
69-75: All referenced test paths exist and are correctly documented.
95-99: Security guidance is accurate and well-implemented.The environment variables are properly validated:
ELECTRIC_INSECUREandELECTRIC_SECRETare mutually exclusive, with runtime errors enforced inlib/electric/config.ex. The distinction between dev and prod configurations is correct, and the warning aboutlib/electric/plug/*changes is appropriate given these modules handle public HTTP API endpoints.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3735 +/- ##
==========================================
+ Coverage 84.01% 87.36% +3.35%
==========================================
Files 44 23 -21
Lines 2834 2011 -823
Branches 534 528 -6
==========================================
- Hits 2381 1757 -624
+ Misses 451 252 -199
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds a AGENTS.md file for the sync-service. At the moment it's very small, but it serves as a starting point to add to as we discover issues to do with the agents not having the right context.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.