Skip to content

Delay sending process finished notification#948

Closed
jeremypw wants to merge 4 commits intomainfrom
jeremypw/delay-notification
Closed

Delay sending process finished notification#948
jeremypw wants to merge 4 commits intomainfrom
jeremypw/delay-notification

Conversation

@jeremypw
Copy link
Copy Markdown
Collaborator

Fixes #947

Certain processes focus out and in rapidly - we should not send a processed finished notification in that case.

@jeremypw jeremypw mentioned this pull request Feb 10, 2026
2 tasks
@danirabbit danirabbit requested a review from a team February 10, 2026 21:26
@danirabbit
Copy link
Copy Markdown
Member

@jeremypw can you resolve conflicts please?

@jeremypw
Copy link
Copy Markdown
Collaborator Author

jeremypw commented Feb 11, 2026

@danirabbit Fixed conflict and in passing reduced some very long lines.

Copy link
Copy Markdown
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to write this with less nesting so we don't have to do so many line breaks? I feel like it actually makes it a lot harder to read. The character limit is also 120 chars so there's a lot of super early wrapping introduced here

@danirabbit danirabbit moved this to Needs review in OS 8.1.1 Feb 11, 2026
@jeremypw
Copy link
Copy Markdown
Collaborator Author

Is there a way to write this with less nesting so we don't have to do so many line breaks? I feel like it actually makes it a lot harder to read. The character limit is also 120 chars so there's a lot of super early wrapping introduced here

I'll do my best. I prefer line lengths less than 100, preferably less than 80 as it is easier for people needing larger font-sizes or want to display to pages side by side (without a large screen). I don't mind the nesting so long as the whole clause is visible on-screen at the same time. Could always make the handlers into separate functions I guess.

@jeremypw jeremypw requested a review from danirabbit February 15, 2026 17:52
@danirabbit
Copy link
Copy Markdown
Member

danirabbit commented Feb 16, 2026

I feel like there's now been too much refactoring mixed in here and I'm not comfortable reviewing this. It's too difficult to see what's the actual bug fix change and what's line break changes and what's other types of refactoring

Also what's been agreed on in the code style guide is a 120 char limit. So I'm not a huge fan of introducing even earlier line breaks that imo make things a lot harder to read

@jeremypw
Copy link
Copy Markdown
Collaborator Author

OK, I'll start again with minimal changes.

@jeremypw jeremypw closed this Feb 17, 2026
@github-project-automation github-project-automation Bot moved this from Needs review to Done in OS 8.1.1 Feb 17, 2026
@jeremypw jeremypw deleted the jeremypw/delay-notification branch February 17, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Process completed notification while terminal is focused

2 participants