Conversation
|
@jeremypw can you resolve conflicts please? |
# Conflicts fixed: # src/Application.vala
|
@danirabbit Fixed conflict and in passing reduced some very long lines. |
danirabbit
left a comment
There was a problem hiding this comment.
Is there a way to write this with less nesting so we don't have to do so many line breaks? I feel like it actually makes it a lot harder to read. The character limit is also 120 chars so there's a lot of super early wrapping introduced here
I'll do my best. I prefer line lengths less than 100, preferably less than 80 as it is easier for people needing larger font-sizes or want to display to pages side by side (without a large screen). I don't mind the nesting so long as the whole clause is visible on-screen at the same time. Could always make the handlers into separate functions I guess. |
|
I feel like there's now been too much refactoring mixed in here and I'm not comfortable reviewing this. It's too difficult to see what's the actual bug fix change and what's line break changes and what's other types of refactoring Also what's been agreed on in the code style guide is a 120 char limit. So I'm not a huge fan of introducing even earlier line breaks that imo make things a lot harder to read |
|
OK, I'll start again with minimal changes. |
Fixes #947
Certain processes focus out and in rapidly - we should not send a processed finished notification in that case.