Conversation
| call_reason = | ||
| if maybe_pid do | ||
| "Error happened when attempting to transfer to #{inspect(maybe_pid)} " <> | ||
| "Error happened when attempting to transfer to #{Util.inspect_pid(maybe_pid)} " <> |
There was a problem hiding this comment.
Note that Util.inspect_pid/1 was updated to fall back to inspect/1 where it's not actually a pid
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
Hi @nathanl, I am a bit conflicting about these changes because the information you are attaching here, in the majority of the cases, is already available as the init function (or similarly named) in the process dictionary, so we are attaching redundant information.
|
Gotcha. If I roll back the |
nathanl
force-pushed
the
more_label_usage
branch
from
86ea0c1 to
c2fd173
Compare
|
@josevalim I rebased to just the |
|
Yes, let's do the inspect_pid for sure. We can even read the initial_call on inspect_pid too (if there is no label). |
|
Added that |
|
Thank you, please fix the tests to be less specific and we should be good to go! |
nathanl
force-pushed
the
more_label_usage
branch
4 times, most recently
from
b49d1e9 to
ddc855d
Compare
|
@josevalim see update |
Whenever possible, have error messages that include a PID also include the process label, name, or initial call.
nathanl
force-pushed
the
more_label_usage
branch
from
29a6f10 to
02bf591
Compare
|
Rebased on master and tests are green |
|
💚 💙 💜 💛 ❤️ |
2 participants
To improve error messages and facilitate debugging.
Whenever possible, have error messages that include a PID also include
the process label, name, or initial call.