Improve send return type inference#15643
Closed
lukaszsamson wants to merge 1 commit into
Closed
Conversation
Teach the type checker that Kernel.send/2 returns the message operand and add a typed signature for :erlang.send/3 status returns. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
|
👍 we can definitely make it more precise. But let's type only send/2 for now. |
Contributor
Author
Addressed in a new one #15644 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:erlang.send/2returns the message term verbatim, but the type checker previously treated it asdynamic(). This made unreachable clauses aftersend/2look possible and lost precision for everyKernel.send/2call because it inlines to:erlang.send/2.Summary
:erlang.send/2remote apply path that returns the computed message operand type.Kernel.send/2identity behavior in module type tests.Tests
make test_stdlib TEST_FILES=module/types/expr_test.exsmake test_formatted