Skip to content

ci: lint with --warnings-as-errors #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhanberg merged 2 commits into from
Feb 9, 2026
Merged

ci: lint with --warnings-as-errors #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86fdff6
ci: lint with --warnings-as-errors
mhanberg Feb 7, 2026
e45d05f
fixup! ci: lint with --warnings-as-errors
mhanberg Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,9 @@ jobs:
- name: Install Dependencies
run: nix develop --command bash -c "mix deps.get"

- name: Compile with --warnings-as-errors
run: nix develop --command bash -c "mix compile --warnings-as-errors"

- name: Run Formatter
run: nix develop --command bash -c "mix format --check-formatted"

Expand Down
2 changes: 1 addition & 1 deletion lib/spitfire.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ defmodule Spitfire do

@terminals MapSet.new([:eol, :eof, :"}", :")", :"]", :">>", :block_identifier])
@terminals_with_comma MapSet.put(@terminals, :",")
defp parse_expression(parser, assoc \\ @lowest, is_list \\ false, is_map \\ false, is_top \\ false)
defp parse_expression(parser, assoc, is_list, is_map, is_top)

defp parse_expression(parser, {associativity, precedence}, is_list, is_map, is_top) do
trace "parse_expression", trace_meta(parser) do
Expand Down
Loading